Allow timer rate to be configurable inmessage_lost_talker
#679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yadunund <[email protected]>
Signed-off-by: Yadunund <[email protected]>
Yadunund
requested review from
adityapande-1995,
audrow and
mjeronimo
as code owners
mjcarroll
requested changes
May 5, 2024
Co-authored-by: Michael Carroll <[email protected]> Signed-off-by: Yadu <[email protected]>
Signed-off-by: Yadunund <[email protected]>
fujitatomoya
requested changes
May 6, 2024
| @@ -156,8 +156,8 @@ and the "Deadline missed" messages will no longer be printed. | |||
| This demo shows how to get a notification when a subscription loses a message. | |||
|
|
|||
| This feature is not available in all RMW implementations. | |||
| `rmw_cyclonedds_cpp` and `rmw_connextdds` do support this feature. | |||
| CycloneDDS partially implements the feature and it only triggers the event under some limited circumstances, thus it's recommended to try the demo with Connext. | |||
| `rmw_zenoh_cpp`, `rmw_cyclonedds_cpp` and `rmw_connextdds` do support this feature. | |||
There was a problem hiding this comment.
i think RMW_EVENT_MESSAGE_LOST is supported in rmw_fastrtps, i am not sure why that is not listed here?
Suggested change
| `rmw_zenoh_cpp`, `rmw_cyclonedds_cpp` and `rmw_connextdds` do support this feature. | |
| `rmw_fastrtps_cpp`, `rmw_zenoh_cpp`, `rmw_cyclonedds_cpp` and `rmw_connextdds` do support this feature. |
There was a problem hiding this comment.
Agreed. I also think it is premature to add in rmw_zenoh_cpp here, as it is not a Tier-1 RMW.
| input_stream >> timer_rate; | ||
| if (!input_stream) { | ||
| print_usage(); | ||
| std::cout << "\n-s must be followed by a positive number, got: '" << |
There was a problem hiding this comment.
Suggested change
| std::cout << "\n-s must be followed by a positive number, got: '" << | |
| std::cout << "\n-r must be followed by a positive number, got: '" << |
| std::exit(0); | ||
| } | ||
| timer_period_ = std::chrono::duration_cast<std::chrono::milliseconds>( | ||
| std::chrono::duration<double, std::ratio<1>>(1.0 / timer_rate)); |
There was a problem hiding this comment.
if -r 0, this could generate 0 division exception?
|
@Yadunund friendly ping 🧇 |
|
Sorry for the delay. Will have this cleaned up by end of this week |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default the talker publishes an 8mB message every 3 seconds. I haven't been able to reproduce any message lost callback triggers with such a low frequency. It helps to increase the publishing rate.
This PR
-rCLI arg tomessage_lost_talkerto configure the timer's period. Default behavior is still the same 3s period.best_effortto increase the probability of dropping a message. -> I can undo this change if needed.