Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start article defining actions #143

Closed
wants to merge 14 commits into from
95 changes: 95 additions & 0 deletions articles/051_actions.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,95 @@
---
layout: default
title: Actions
permalink: articles/actions.html
abstract:
Despite their implementation as a separate library and lack of a detailed specification, actions are one of the three core types of interaction between ROS nodes. Their asynchronous nature combined with the feedback and control mechanism gives them significantly more power than a standard RPC. This article formalises the requirements for actions, including what a ROS user should see and what the middleware layer should provide.
author: '[Geoffrey Biggs](https://github.com/gbiggs)'
published: true
---

{:toc}

# {{ page.title }}

<div class="abstract" markdown="1">
{{ page.abstract }}
</div>

Original Author: {{ page.author }}

## Background

ROS services, which provide synchronous Remote Procedure Calls, are a useful concept for sending a request and getting a rapid reply. But in robotics there are many instances where a reply may take a significant length of time. Additionally, there are occasions when it is useful to send a request to do some processing or perform some action in the world, where the result is less important than the effect of carrying it out. The progress of such requests often needs to be tracked, success or failure must be known in addition to receiving back information produced, and the request may need to be cancelled or altered before it completes. These requirements cannot be fulfilled by a simple RPC mechanism, whether or not it is asynchronous.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ROS 1 services were indeed only synchronous, but ROS 2 services can be asynchronous. It is true however that most of the time they are used for short synchronous requests.


"in addition to receiving feedback information"?


To satisfy these use cases, ROS provides a third communication paradigm known as "actions". An action is a goal-oriented request that occurs asynchronously to the requester, is typically (but not necessarily) longer-running than immediate, can be cancelled or replaced during execution, and has a server that provides feedback on execution progress.

This document defines how actions are specified, what they look like to ROS users (both node developers and system integrators)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: punctuation


## Action specification

Actions are specified using a form of the ROS Message IDL. The specification contains three sections, each of which is a message specification:

1. Goal

1. Result

1. Feedback

Any of these sections may be empty.

Between the three sections is a line containing three hyphens, `---`.

Action specifications are stored in a file ending in `.action`. There is one action specification per `.action` file.

An example action specification [taken from the actionlib wiki] is shown below.

```
# Define the goal
uint32 dishwasher_id # Specify which dishwasher we want to use
---
# Define the result
uint32 total_dishes_cleaned
---
# Define a feedback message
float32 percent_complete
uint32 number_dishes_cleaned
```

## Serving and using actions

Actions are a first-class citizen in the ROS API, alongside topics and services.

Action clients will use an API that provides a proxy object for the action. This will be a templated class, using the action class generated from the action specification as the template parameter. The client shall create an instance of this class, providing the address of the intended action server. Each instance of this class can only be related to one action server. Methods of the class will provide facilities for sending a goal to the action server, receiving a result, and getting feedback.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order to enforce the one action server per address, we would need to ensure this at the service level which we don't right now. This is tied to the node name uniqueness issue which we still haven't addressed yet.

We can set that as a goal, but when it comes time to implement we may just have to push this problem for the time being.


Action servers will use an API that provides a templated server class, using the action class generated from the action specification as the template parameter. The node implementer will create a function that implements the action's behaviour, create an instance of the templated server class, and bind the implementing function to the server. The implementing function will receive as one of its parameters the received goal message, and as another parameter the action server instance. The implementation shall use the action server instance to provide progress feedback and to report the result and success/failure/error status of the action's execution.

Actions may be used from or served by real-time nodes. Therefore the actions API must be real-time capable.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good goal, but we'll have to make some more qualifications on this most likely. We'd also have to make sure services are real-time, which I'm not sure they necessarily are at the moment.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not all use cases would necessarily need to be supported in realtime. If there's an asynchronous API such that the realtime thread can poll/pump the action client/server without blocking that could be made realtime safe. I'd suggest qualifying this assertion to suggest that there's at least one approach that's realtime safe.


## Introspection tools

Actions, like topics and services, are introspectable from the command line.

In ROS 1, actions are visible in the output of the `rostopic` tool.

In ROS 2, actions will not be visible as a set of topics. Nor will they be visible as a set of services [in the case that services be used to implement them]. They will be visible using a separate `ros2 action` command line tool.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wjwwood @tfoote @gbiggs - is it possible to have a topic be 'hidden' or 'private' in some way that makes it invisible to the 'ros2 topic list' command? Similarly can a service be hidden? If so I was thinking the Action message interface is a combination of an 'hidden' asynchronous service and a 'hidden' topic. Is that possible?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is the notion of hidden topics and services. Topics/services starting with an underscore _ are considered "hidden".
Design doc reference: http://design.ros2.org/articles/topic_and_service_names.html#hidden-topic-or-service-names
The commandline tools will not show these topics by default but should provide a flag to display them.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mikaelarguedas - Thank you for the fast answer. So given that is the case, can Action servers be implemented as a class that internally creates both a hidden service and a hidden topic? Likewise an action client would call that service and subscribe to that topic.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I think this is doable 👍

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mikaelarguedas - given that is true, there are at least 2 ways to implement this I can think of:

  1. Port actionlib and actionlib_msgs directly, except adding the "hiding" of topic and service names
  • This would be the most straight 'port' possible
  • Would still need to update the ros2utils to add the 'ros2 actions' functions. This is needed no matter what option is chosen
  • don't know what colcon / ament build changes are needed if any
  1. Create new ActionServer and ActionClient classes for ROS2, with create_action_server and create_action_client as part of the node interface available in rclpy and rclcpp
  • This would make Actions available through the node interface directly, just like Topics and Services
  • They could be implemented internally as 'hidden' topics and services
  • still need to add the 'ros2 actions' functions
  • don't know what colcon / ament build changes are needed if any

Any other options? I think Actions could be plumbed down all the way to the RMW layer but I don't know how beneficial that would be, and it might result in unneeded code duplication of what is in Services and Topics today.

Please share your thoughts on this. My team is going to be blocked by this for Navigation, but if we can figure out the design, we could potentially help with some of the implementation work.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm in favour of option 2, because I want to see actions be treated as first-class citizens like topics and services in ROS 2, not the ignored illegal alien that they are in ROS 1 tooling.

A simple implementation would be to just use hidden topics and services, and I see this as being the easiest way to go to prototype the API. Since the implementation and the high-level API/tooling design should be relatively independent, this could be a good way to get something useable out. However, I wouldn't want this to lead to stagnation that results in a better implementation that takes advantage of available rmw/DDS features not being produced. I'm very keen to hear what the OSRF people had thought about how DDS would be leveraged for actions.


The command line tool will be similar to the `ros2 service` tool. It will be able to:

- list known actions,
- display the arguments for an action's goal,
- display the type of an action's feedback and result,
- display information about the server of an action,
- display the underlying topics and/or services providing the action,
- find actions by action type, and
- call an action, display feedback as it is received, display the result when received, and cancel the action (when the tool is terminated prematurely)

Each action, despite using multiple topics and/or services in its implementation, will be listed and treated as a single unit by this tool. [This will probably be a namespace that contains the underlying topics, etc.]

## Middleware implementation

In ROS 1, actions are implemented using a set of topics under a namespace taken from the action name. This implementation was chosen because ROS services are inherently synchronous, and so incompatible with the asynchronous nature of the action concept. There is also a need for a status/feedback channel and a control channel.

The Remote Procedure Call over DDS (DDS-RPC) specification does not explicitly provide facilities for interrupting service calls or receiving feedback on their progress. It does provide for receiving both a return value from a request and, at the same time, an indication of whether the request was successful or raised an exception, with the exception type included in this information.

This means that an implementation of actions cannot simply be a DDS-style RPC. The implementation must separately provide status/feedback and control channels. While a control channel could be implemented as a separate RPC, due to the dataflow nature of feedback it would be best implemented as a separate topic.