Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding StaticTransformListener in Python #719

Open
wants to merge 4 commits into
base: rolling
Choose a base branch
from
Open

Adding StaticTransformListener in Python #719

wants to merge 4 commits into from
+159 −32

Conversation

CursedRock17
Copy link
Contributor

As per the title, this pull request is meant to compliment #673 and hopefully close #662 by adding the StaticTransformListener in Python.

@CursedRock17 CursedRock17 marked this pull request as ready for review October 26, 2024 04:13
ahcorde
ahcorde requested changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you also add the test ?

tf2_ros_py/tf2_ros/static_transform_listener.py Outdated
@@ -0,0 +1,111 @@
# Copyright (c) 2008, Willow Garage, Inc.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Copyright (c) 2008, Willow Garage, Inc.
# Copyright (c) 2024, Open Source Robotics Foundation, Inc.

tf2_ros_py/tf2_ros/static_transform_listener.py Outdated Show resolved Hide resolved
tf2_ros_py/tf2_ros/static_transform_listener.py Outdated Show resolved Hide resolved
@CursedRock17
Adjusting file
9e1a733 
Signed-off-by: CursedRock17 <[email protected]>
@CursedRock17
Copy link
Contributor Author

can you also add the test ?

As in a whole new testing suite or another set of individualized tests? The StaticTransformListener should be applicable in test_static_broadcaster_and_listener, just a faster version of the TransformListener.

@ahcorde
Copy link
Contributor

ahcorde commented Oct 31, 2024

can you also add the test ?

As in a whole new testing suite or another set of individualized tests? The StaticTransformListener should be applicable in test_static_broadcaster_and_listener, just a faster version of the TransformListener.

The mentioned PR adds some new tests to test_transform_listener.cpp, I would suggest to add something similar to tf2_ros_py

@CursedRock17
Adding smaller tests
a226e4e 
Signed-off-by: CursedRock17 <[email protected]>
@ahcorde
Copy link
Contributor

ahcorde commented Nov 6, 2024

Pulls: #719
Gist: https://gist.githubusercontent.com/ahcorde/8eca404e13a04ad871146a39db4cdcc2/raw/9d524ee1ccc2723415616719d3026e29857f0835/ros2.repos
BUILD args: --packages-above-and-dependencies tf2_ros_py --packages-above-and-dependencies tf2_ros_py
TEST args: --packages-above tf2_ros_py --packages-above tf2_ros_py
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14794

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde approved these changes

@clalancette clalancette Awaiting requested review from clalancette clalancette is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a StaticTransformListener
2 participants
@CursedRock17 @ahcorde