Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow optional scoping for including a launchfile #801

Open
SuperJappie08 opened this issue Oct 9, 2024 · 0 comments
Open

Allow optional scoping for including a launchfile #801

SuperJappie08 opened this issue Oct 9, 2024 · 0 comments
Assignees

Comments

@SuperJappie08
Copy link

SuperJappie08 commented Oct 9, 2024

Feature request

IncludeLaunchDescription is not scoped if I understand correctly. (Based on #313 #689 and the design docs)

Feature description

An extra argument for IncludeLaunchDescription action, which could enable scoping.
This would prevent the leakage of arguments.

Implementation considerations

This is already possible by including into a group with forwarding set to false.
Default could be false to not break the current behavior.

EDIT: I made a proof of concept package https://github.com/SuperJappie08/launch_scoped_include/, which implements this on a new action called IncludeScopedLaunchDescription

EDIT2: I can make a pull request for this if the feature is desired

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants