-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Name remapping specific to a fully-qualified node's name #296
Comments
The node-name prefix handling assumes node names are unique (edit: that is, not including the namespace) within a process before remapping. |
Usually when we refer to node name uniqueness we are actually referring to "ns+node name" uniqueness. To clarify your statement: the remapping process is assuming there is only one |
Correct |
I think it has to consider the node namespace as well, because having two nodes with the same name but in different namespaces will be (has been in the past) a common case. |
👍
👍 Agreed I think it should consider the namespace and assume uniqueness of "ns+node name". I often use the example of a stereo image processing process that is a basic/common example of a process having 2 instances of a "camera" node under different namespaces ( |
It seems that this feature is still not supported in ros2. I'd like to contribute to this issue.
|
Actually, I found |
To remap __node and __ns with Lines 199 to 207 in 8bcada7
Lines 240 to 248 in 8bcada7
|
I have created a new PR for this issue at ros2/design#299 that also including #806, could you please help review it? |
Remapping can be passed to a specific node with e.g.
talker:chatter:=my_chatter
.Suppose I have multiple nodes named
talker
in a process, but in different namespaces.Is the ability to address the nodes individually implemented yet, so that I can do e.g.
/ns1/talker:chatter:=my_chatter
? I think not; am looking for confirmation. @sloretzThe text was updated successfully, but these errors were encountered: