Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add QoS Profile/Depth support to Node. #1376

Open
wants to merge 4 commits into
base: rolling
Choose a base branch
from
Open

add QoS Profile/Depth support to Node. #1376

wants to merge 4 commits into from

Conversation

fujitatomoya
Copy link
Collaborator

@fujitatomoya fujitatomoya commented Nov 3, 2024 •
edited
Loading

closes #1368

depends on ros2/rmw#381

@fujitatomoya fujitatomoya mentioned this pull request Nov 3, 2024
Open
@fujitatomoya
Copy link
Collaborator Author

@ahcorde @clalancette please take a look if you have time.

ahcorde
ahcorde requested changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flake8 is failing https://build.ros2.org/job/Rpr__rclpy__ubuntu_noble_amd64/400/

@fujitatomoya
Copy link
Collaborator Author

Pulls: #1376
Gist: https://gist.githubusercontent.com/fujitatomoya/2288c082a6b12e1b69cb9fa1878b9ffc/raw/a5f536d8bd4673a5e2b08457b15bffc4b3d52e55/ros2.repos
BUILD args: --packages-above-and-dependencies rclpy
TEST args: --packages-above rclpy
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14780

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

clalancette
clalancette requested changes Nov 4, 2024
View reviewed changes
rclpy/test/test_create_node.py Outdated Show resolved Hide resolved
rclpy/rclpy/__init__.py Outdated Show resolved Hide resolved
@fujitatomoya
Copy link
Collaborator Author

@clalancette thanks for the review and information. i agree with your comments, i will try to address them.

@fujitatomoya fujitatomoya force-pushed the fujitatomoya/node-rosout-qos-profile-support branch from 987bc36 to 1e5a670 Compare November 6, 2024 20:36
@fujitatomoya fujitatomoya mentioned this pull request Nov 6, 2024
Open
@fujitatomoya
address flake8 warnings.
774696e 
Signed-off-by: Tomoya Fujita <[email protected]>
@fujitatomoya
Copy link
Collaborator Author

@clalancette this is ready to review.

to expose default rosout qos profile to rclpy, it requires the following changes.

@fujitatomoya
Copy link
Collaborator Author

either @clalancette or @ahcorde friendly ping.

@fujitatomoya
Copy link
Collaborator Author

Pulls: #1376, ros2/rmw#381, ros2/rcl#1195, ros2/rclcpp#2663
Gist: https://gist.githubusercontent.com/fujitatomoya/e4ad476b64d3f274940ae31ebe7149e3/raw/2fa0833cd5e3edd9602385b88d556cb0d18ad054/ros2.repos
BUILD args: --packages-above-and-dependencies rclpy rmw rcl rclcpp
TEST args: --packages-above rclpy rmw rcl rclcpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14837

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

This was referenced Nov 19, 2024
Open
Open
@ahcorde
Copy link
Contributor

ahcorde commented Nov 20, 2024

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya
Copy link
Collaborator Author

@ahcorde @clalancette CI failures are unrelated to these changes, i would like to request the reviews. (see #1376 (comment))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sloretz sloretz Awaiting requested review from sloretz

@adityapande-1995 adityapande-1995 Awaiting requested review from adityapande-1995

@ahcorde ahcorde Awaiting requested review from ahcorde

@clalancette clalancette Awaiting requested review from clalancette

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No way to set rosout QoS for a Node
3 participants
@fujitatomoya @ahcorde @clalancette