Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document which QoS policies are correctly read by rmw_get_publishers/subscriptions_info_by_topic #308

Merged
merged 6 commits into from
Apr 13, 2021

Conversation

ivanpauno
Copy link
Member

…subscriptions_info_by_topic

Signed-off-by: Ivan Santiago Paunovic <[email protected]>
@ivanpauno ivanpauno added the enhancement New feature or request label Apr 12, 2021
@ivanpauno ivanpauno requested review from jacobperron and hidmic April 12, 2021 14:10
@ivanpauno ivanpauno self-assigned this Apr 12, 2021
Copy link
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I guess some RMW implementations should probably be updated to match this documentation. In that case, this may be considered an API change and perhaps we should hold until after we branch for Galactic.

ivanpauno and others added 2 commits April 12, 2021 13:49
Signed-off-by: Ivan Santiago Paunovic <[email protected]>

Co-authored-by: Jacob Perron <[email protected]>
Signed-off-by: Ivan Santiago Paunovic <[email protected]>

Co-authored-by: Jacob Perron <[email protected]>
@ivanpauno
Copy link
Member Author

LGTM

I guess some RMW implementations should probably be updated to match this documentation. In that case, this may be considered an API change and perhaps we should hold until after we branch for Galactic.

The rmw implementations already match this behavior, so this is only documentation.

I don't remember if they set the policies that are not updated to RMW_QOS_POLICY_*_UNKNOWN, so I can delete that line of the docs.
But I think they should be doing that, if not it's hard/impossible to understand the output.

ivanpauno and others added 3 commits April 13, 2021 10:29
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
Co-authored-by: William Woodall <[email protected]>
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
@ivanpauno ivanpauno force-pushed the ivanpauno/get-info-by-topic-docs branch from bc07bf9 to 10b6c6b Compare April 13, 2021 13:30
@ivanpauno
Copy link
Member Author

I don't remember if they set the policies that are not updated to RMW_QOS_POLICY_*_UNKNOWN, so I can delete that line of the docs.
But I think they should be doing that, if not it's hard/impossible to understand the output.

Fastrtps was already doing that https://github.com/ros2/rmw_fastrtps/blob/7bb3563bebd20c3cae03231c2e321bf132651449/rmw_fastrtps_shared_cpp/include/rmw_fastrtps_shared_cpp/custom_participant_info.hpp#L149.
Cyclonedds shares through discovery all qos policies.

I send a patch to connextdds to fix this ros2/rmw_connextdds#28.

@ivanpauno
Copy link
Member Author

PR checker is happy, this a docs only PR so no need of more CI.

@ivanpauno ivanpauno merged commit 5b9c50b into master Apr 13, 2021
@delete-merged-branch delete-merged-branch bot deleted the ivanpauno/get-info-by-topic-docs branch April 13, 2021 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants