Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

introduce RMW_EVENT_TYPE_MAX in rmw_event_type_t. #518

Open
wants to merge 3 commits into
base: rolling
Choose a base branch
from
Open

introduce RMW_EVENT_TYPE_MAX in rmw_event_type_t. #518

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6af180a
introduce RMW_EVENT_TYPE_MAX in rmw_event_type_t.
fujitatomoya Oct 16, 2024
984924e
add a case for RMW_EVENT_TYPE_MAX to rmw_take_event().
fujitatomoya Oct 17, 2024
59b391f
remove redundant blank lines, make cpplint happy.
fujitatomoya Oct 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions rmw_cyclonedds_cpp/src/rmw_node.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -747,6 +747,7 @@ extern "C" rmw_ret_t rmw_event_set_callback(
}

case RMW_EVENT_INVALID:
case RMW_EVENT_TYPE_MAX:
{
return RMW_RET_INVALID_ARGUMENT;
}
Expand Down Expand Up @@ -4061,12 +4062,10 @@ extern "C" rmw_ret_t rmw_take_event(
return RMW_RET_OK;
}

case RMW_EVENT_INVALID: {
case RMW_EVENT_INVALID:
case RMW_EVENT_TYPE_MAX: {
break;
}

default:
rmw_cyclonedds_cpp::unreachable();
}
*taken = false;
return RMW_RET_ERROR;
Expand Down