Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ctrl+c not killing ros2 cli tools when the rmw_zenohd router is not running #236

Open
jmount1992 opened this issue Jul 3, 2024 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@jmount1992
Copy link

As a user I would expect that pressing ctrl+c when running a ros2 cli tool such as ros2 topic list or ros2 node list would kill the process. However, if a Zenoh router isn't running this signal isn't handled and it continues to print the default behaviour message of [ERROR] [1719974909.135681607] [rmw_zenoh_cpp]: Unable to connect to a Zenoh router. Have you started a router with ros2 run rmw_zenoh_cpp rmw_zenohd? I understand the default behaviour can be changed. However, I would expect users would still expect ctrl+c to kill this process.

@Yadunund Yadunund changed the title ctrl+c not killing ros2 cli tools ctrl+c not killing ros2 cli tools when the rmw_zenohd router is not running Jul 3, 2024
@Yadunund
Copy link
Member

Yadunund commented Jul 3, 2024

This is a known issue with signal handlers in rclpy + issues in rmw_shutdown. See #135 (review)

We don't have a solution yet but hoping this will be addressed when we resolve #170.

@Yadunund Yadunund added the bug Something isn't working label Jul 3, 2024
@jmount1992
Copy link
Author

Perfect. I hadn't seen any issue mentioning it so I wanted to bring it to your attention given the rmw_zenoh is in its infancy.

@Yadunund
Copy link
Member

Yep it's good to have this ticket! We are working on addressing it.

@Yadunund
Copy link
Member

Yadunund commented Sep 3, 2024

Still an issue after ros2/rclpy#1331

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants