Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve bridge command parser #399

Closed
wants to merge 23 commits into from
Closed

Improve bridge command parser #399

wants to merge 23 commits into from

Conversation

paulbovbel
Copy link
Contributor

From #396

@LucasHaug
Refactor command parser to use vector of char*
041a53b 
Signed-off-by: LucasHaug <[email protected]>
@LucasHaug
Add argc argv splitter to dynamic bridge
82bdd30 
Signed-off-by: LucasHaug <[email protected]>
@LucasHaug
Add argc argv splitter to paramter bridge
5359817 
Signed-off-by: LucasHaug <[email protected]>
@LucasHaug
Update github action
fd96bcf 
Signed-off-by: LucasHaug <[email protected]>
@LucasHaug
Fix parameter bridge argv split
40dd1b2 
Signed-off-by: LucasHaug <[email protected]>
@LucasHaug
Remove static argv reading
883d777 
Signed-off-by: LucasHaug <[email protected]>
@LucasHaug
Add command parser to parameter bridge
ce8b178 
Signed-off-by: LucasHaug <[email protected]>
@LucasHaug
Fix compilation errors
2911f8f 
Signed-off-by: LucasHaug <[email protected]>
@LucasHaug
Fix compilation errors
8650d49 
Signed-off-by: LucasHaug <[email protected]>
@LucasHaug
Fix parameter bidge command parser
f5f39a1 
Signed-off-by: LucasHaug <[email protected]>
@LucasHaug
Refactor to add command parser utils file
b99c2a3 
Signed-off-by: LucasHaug <[email protected]>
@LucasHaug
Add github action issue workaround
2e47d5e 
Signed-off-by: LucasHaug <[email protected]>
@LucasHaug
Ty to run github action inside container
7bcbb2d 
Signed-off-by: LucasHaug <[email protected]>
@LucasHaug
Fix ROS2 args when no ROS1 args
7d32936 
Signed-off-by: LucasHaug <[email protected]>
@LucasHaug
⏪ Revert changes on GitHub Action config
9a341f2 
Signed-off-by: LucasHaug <[email protected]>
@LucasHaug
Change parameter bridge ROS init order
3b00615 
Signed-off-by: LucasHaug <[email protected]>
@LucasHaug
Rename parser functions
38460e6 
Signed-off-by: LucasHaug <[email protected]>
@LucasHaug
Add get_option_values function
1097b4f 
Signed-off-by: LucasHaug <[email protected]>
@LucasHaug
Fix wrong help for the parameter bridge
02e1d27 
Signed-off-by: LucasHaug <[email protected]>
@LucasHaug
Fix get_option_values parser function
5804cdc 
Signed-off-by: LucasHaug <[email protected]>
@LucasHaug
Refactor bridges to use the get_option_values
d76cb81 
Signed-off-by: LucasHaug <[email protected]>
@LucasHaug
Add running scetion to README
daf83db 
Signed-off-by: LucasHaug <[email protected]>
@LucasHaug
Add print pairs to parameter bridge
d557b00
@paulbovbel
Copy link
Contributor Author

Wrong repository, please disregard

@paulbovbel paulbovbel closed this Apr 6, 2023
@mergify
Copy link

mergify bot commented Apr 6, 2023

⚠️ The sha of the head commit of this PR conflicts with #396. Mergify cannot evaluate rules on this PR. ⚠️

@paulbovbel paulbovbel deleted the improve-bridge-command-parser branch April 12, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@methylDragon methylDragon Awaiting requested review from methylDragon methylDragon is a code owner

@quarkytale quarkytale Awaiting requested review from quarkytale quarkytale is a code owner

@gbiggs gbiggs Awaiting requested review from gbiggs gbiggs is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulbovbel @LucasHaug