Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Using-ROS2-Launch-For-Large-Projects.rst #3787

Merged
merged 3 commits into from
Jul 18, 2023

Conversation

mawo0030
Copy link
Contributor

Added modules to make colcon build work.
(While following the tutorial I ran into the issue that I couldn't build without the proposed changes)

Apparently necessary modules to make colcon build work.
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, excellent point. Thank you for the fix!

@clalancette clalancette added the backport-all backport at reviewers discretion; from rolling to all versions label Jul 18, 2023
Signed-off-by: Chris Lalancette <[email protected]>
Signed-off-by: Chris Lalancette <[email protected]>
@clalancette clalancette merged commit 3ba37f9 into ros2:humble Jul 18, 2023
3 checks passed
@clalancette
Copy link
Contributor

@Mergifyio backport iron rolling

@mergify
Copy link
Contributor

mergify bot commented Jul 18, 2023

backport iron rolling

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jul 18, 2023
* Update Using-ROS2-Launch-For-Large-Projects.rst

Apparently necessary modules to make colcon build work.

Co-authored-by: Chris Lalancette <[email protected]>
(cherry picked from commit 3ba37f9)
mergify bot pushed a commit that referenced this pull request Jul 18, 2023
* Update Using-ROS2-Launch-For-Large-Projects.rst

Apparently necessary modules to make colcon build work.

Co-authored-by: Chris Lalancette <[email protected]>
(cherry picked from commit 3ba37f9)
clalancette pushed a commit that referenced this pull request Jul 18, 2023
* Update Using-ROS2-Launch-For-Large-Projects.rst

Apparently necessary modules to make colcon build work.

Co-authored-by: Chris Lalancette <[email protected]>
(cherry picked from commit 3ba37f9)

Co-authored-by: mawo0030 <[email protected]>
clalancette pushed a commit that referenced this pull request Jul 18, 2023
* Update Using-ROS2-Launch-For-Large-Projects.rst

Apparently necessary modules to make colcon build work.

Co-authored-by: Chris Lalancette <[email protected]>
(cherry picked from commit 3ba37f9)

Co-authored-by: mawo0030 <[email protected]>
@mawo0030 mawo0030 deleted the patch-1 branch July 18, 2023 19:06
@mawo0030
Copy link
Contributor Author

mawo0030 commented Jul 18, 2023

Yes, excellent point. Thank you for the fix!

I feel appreciated and useful today, thank you ❤️
Next time I won't mess with indentation, whitespaces before I open a Pull request, I promise 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-all backport at reviewers discretion; from rolling to all versions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants