Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Visualizing ROS 2 data with Foxglove #4620

Open
wants to merge 11 commits into
base: rolling
Choose a base branch
from

Conversation

banisadr
Copy link

The current how-to guide for Foxglove with ROS 2 is outdated and contains multiple factual inaccuracies. Updating to correct.

@banisadr banisadr marked this pull request as ready for review August 30, 2024 02:48
@banisadr
Copy link
Author

@clalancette @audrow could I get a review when you have a chance?

@defunctzombie
Copy link

cc @kscottz

@kscottz
Copy link
Collaborator

kscottz commented Sep 17, 2024

I hit the CI for you and did a cursory review. I didn't see anything wrong with the update itself.

One thing that I think might need discussion is the location in the document tree. We've been moving most of the third-party project documents to this location. I believe the original file may pre-date that recedent. If we're updating this doc we should update the location as well. @clalancette @fujitatomoya do you have any thoughts with regard to this?

@fujitatomoya
Copy link
Collaborator

One thing that I think might need discussion is the location in the document tree. We've been moving most of the third-party project documents to this location.

i think this is good idea.

@banisadr btw, awesome gundom picture, i love that.

@clalancette
Copy link
Contributor

One thing that I think might need discussion is the location in the document tree. We've been moving most of the third-party project documents to this location. I believe the original file may pre-date that recedent. If we're updating this doc we should update the location as well. @clalancette @fujitatomoya do you have any thoughts with regard to this?

Yeah, I actually agree that we should move this to the "Related Projects" part of the site, because it is not part of the core. So @banisadr please do that as well.

@fujitatomoya fujitatomoya added the more-information-needed Further information is required label Oct 4, 2024
@fujitatomoya
Copy link
Collaborator

@banisadr friendly ping

@banisadr
Copy link
Author

banisadr commented Oct 4, 2024

Thanks @fujitatomoya @clalancette @kscottz! I moved it over to related projects and did a local test build. Nav/ToC seem to be working. Let me know if there's anything else I should update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
more-information-needed Further information is required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants