Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ROS 1 to ROS 2 migration note for group parameter handling (backport #4983) #5002

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Feb 7, 2025

Add information to help developers safely migrate parameter updates by highlighting that ROS 2's default set_parameters service behaves differently than ROS 1's dynamic_reconfigure regarding atomic updates. Points users to set_parameters_atomically service to maintain atomic behavior during migration.


This is an automatic backport of pull request #4983 done by Mergify.

* Add ROS 1 to ROS 2 migration note for group parameter handling

Add information to help developers safely migrate parameter updates by
highlighting that ROS 2's default set_parameters service behaves
differently than ROS 1's dynamic_reconfigure regarding atomic updates.
Points users to set_parameters_atomically service to maintain atomic
behavior during migration.

* Remove 'default' terminology from parameter services note

* Adapt the structure of the migration guide from ROS 1 to ROS 2

* Refactor based on code review

* Fix console code-block

(cherry picked from commit 3dbac70)
@mergify mergify bot requested review from clalancette and audrow as code owners February 7, 2025 18:33
Copy link

github-actions bot commented Feb 7, 2025

HTML artifacts: https://github.com/ros2/ros2_documentation/actions/runs/13205901910/artifacts/2555956904.

To view the resulting site:

  1. Click on the above link to download the artifacts archive
  2. Extract it
  3. Open html-artifacts-5002/index.html in your favorite browser

@fujitatomoya fujitatomoya merged commit 2974bf2 into jazzy Feb 7, 2025
5 checks passed
@fujitatomoya fujitatomoya deleted the mergify/bp/jazzy/pr-4983 branch February 7, 2025 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants