Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rosbag2 qos override documentation #627

Merged
merged 1 commit into from
Apr 24, 2020

Conversation

piraka9011
Copy link
Contributor

@piraka9011 piraka9011 commented Apr 23, 2020

rosbag2 added a new feature for Foxy where users can specify QoS policy overrides from the CLI to record/playback topics offering different QoS policies.

This adds documentation on how to use the feature.

Part of ros2/rosbag2#125 and ros2/rosbag2#357.
Part of ros-tooling/aws-roadmap#244.

Signed-off-by: Anas Abou Allaban [email protected]

Signed-off-by: Anas Abou Allaban <[email protected]>
@piraka9011
Copy link
Contributor Author

@maryaB-osr Could I get a review on this please?
Let me know whether I need to move things around.

@maryaB-osr
Copy link
Contributor

It looks like your Tutorials.rst page is out of date. The sections are organized a bit differently now: https://index.ros.org/doc/ros2/Tutorials/

So there is actually an intermediate section you can put this tutorial in

Copy link
Contributor

@maryaB-osr maryaB-osr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like there's no merge conflict even though Tutorials.rst is out of date. So I'll approve it anyway, this tutorial can be moved to the right section any time. You probably want to update your fork though.

Thanks for the content!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants