Skip to content

Commit

Permalink
Use foxy testing apt repos to install linters for Actions (#463)
Browse files Browse the repository at this point in the history
* Use foxy testing apt repos to install linters for Actions

Signed-off-by: Emerson Knapp <[email protected]>
  • Loading branch information
emersonknapp authored and Emerson Knapp committed Feb 17, 2021
1 parent 1e25d22 commit b229399
Showing 1 changed file with 9 additions and 9 deletions.
18 changes: 9 additions & 9 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
@@ -1,8 +1,4 @@
# Run linters automatically on pull requests.
#
# ros-tooling/actino-ros-lint is relying on the latest APT binary packages.
# As of 2020-05-01, Eloquent is the latest release for which APT binary
# packages are available, which is why the Docker image is based on Eloquent.
name: Lint rosbag2
on:
pull_request:
Expand All @@ -12,14 +8,15 @@ jobs:
name: ament_copyright
runs-on: ubuntu-latest
container:
image: rostooling/setup-ros-docker:ubuntu-bionic-ros-eloquent-ros-base-latest
image: rostooling/setup-ros-docker:ubuntu-focal-ros-foxy-ros-base-testing-latest
steps:
# TODO(setup-ros-docker#7): calling chown is necessary for now
- run: sudo chown -R rosbuild:rosbuild "$HOME" .
- uses: actions/checkout@v2
- uses: ros-tooling/[email protected]
with:
linter: copyright
distribution: foxy
package-name: |
ros2bag
rosbag2_compression
Expand All @@ -34,14 +31,15 @@ jobs:
name: ament_xmllint
runs-on: ubuntu-latest
container:
image: rostooling/setup-ros-docker:ubuntu-bionic-ros-eloquent-ros-base-latest
image: rostooling/setup-ros-docker:ubuntu-focal-ros-foxy-ros-base-testing-latest
steps:
# TODO(setup-ros-docker#7): calling chown is necessary for now
- run: sudo chown -R rosbuild:rosbuild "$HOME" .
- uses: actions/checkout@v2
- uses: ros-tooling/[email protected]
with:
linter: xmllint
distribution: foxy
package-name: |
ros2bag
rosbag2
Expand All @@ -57,19 +55,20 @@ jobs:
ament_lint_cpp: # Linters applicable to C++ packages
name: ament_${{ matrix.linter }}
runs-on: ubuntu-latest
container:
image: rostooling/setup-ros-docker:ubuntu-bionic-ros-eloquent-ros-base-latest
strategy:
fail-fast: false
matrix:
linter: [cppcheck, cpplint, uncrustify]
container:
image: rostooling/setup-ros-docker:ubuntu-focal-ros-foxy-ros-base-testing-latest
steps:
# TODO(setup-ros-docker#7): calling chown is necessary for now
- run: sudo chown -R rosbuild:rosbuild "$HOME" .
- uses: actions/checkout@v2
- uses: ros-tooling/[email protected]
with:
linter: ${{ matrix.linter }}
distribution: foxy
package-name: |
rosbag2_compression
rosbag2_converter_default_plugins
Expand All @@ -83,7 +82,7 @@ jobs:
name: ament_${{ matrix.linter }}
runs-on: ubuntu-latest
container:
image: rostooling/setup-ros-docker:ubuntu-bionic-ros-eloquent-ros-base-latest
image: rostooling/setup-ros-docker:ubuntu-focal-ros-foxy-ros-base-testing-latest
strategy:
fail-fast: false
matrix:
Expand All @@ -95,5 +94,6 @@ jobs:
- uses: ros-tooling/[email protected]
with:
linter: ${{ matrix.linter }}
distribution: foxy
package-name: |
ros2bag

0 comments on commit b229399

Please sign in to comment.