Add unit tests to cover message's send and received timestamps during recording #1641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- CycloneDDS doesn't support 'received_timestamps' and settling up zeros in message_info for that field. - Fallback to the timestamp from node clock in case of the CycloneDDS. Signed-off-by: Michael Orlov <[email protected]>
MichaelOrlov
requested review from
gbiggs,
jhdcs,
clalancette and
marcoag
and removed request for
a team,
gbiggs and
jhdcs
fujitatomoya
approved these changes
May 7, 2024
ahcorde
approved these changes
May 7, 2024
marcoag
approved these changes
May 7, 2024
clalancette
reviewed
May 7, 2024
emersonknapp
approved these changes
May 7, 2024
Signed-off-by: Michael Orlov <[email protected]>
- Also fixed typo in 'rwm_has_send_timestamp_support' in test Signed-off-by: Michael Orlov <[email protected]>
- The fix will be done on the `rmw_cyclonedds` layer in the scope of the ros2/rmw_cyclonedds#491 Signed-off-by: Michael Orlov <[email protected]>
|
So with ros2/rmw_cyclonedds#491 now merged, this one isn't strictly required. Totally up to you if you want to add in the additional tests here, but I'm going to suggest that if we do that, we do not backport to Jazzy at this time. |
MichaelOrlov
changed the title
|
Pulls: #1641
|
delete-merged-branch
bot
deleted the
morlov/workaround-for-zeros-in-received_timestamps-with-cyclone_dds
branch
|
https://github.com/Mergifyio backport jazzy |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
May 23, 2024
… recording (#1641) * Workaround for zeros in a message's received timestamp with CycloneDDS - CycloneDDS doesn't support 'received_timestamps' and settling up zeros in message_info for that field. - Fallback to the timestamp from node clock in case of the CycloneDDS. Signed-off-by: Michael Orlov <[email protected]> * Fix typo in rmw_has_received_timestamp_support Signed-off-by: Michael Orlov <[email protected]> * Add one more check in tests that "recv_timestamp >= send_timestamp" - Also fixed typo in 'rwm_has_send_timestamp_support' in test Signed-off-by: Michael Orlov <[email protected]> * Revert workaround for `rmw_cyclonedds` in recorder.cpp - The fix will be done on the `rmw_cyclonedds` layer in the scope of the ros2/rmw_cyclonedds#491 Signed-off-by: Michael Orlov <[email protected]> --------- Signed-off-by: Michael Orlov <[email protected]> (cherry picked from commit b7d9b5b)
MichaelOrlov
added a commit
that referenced
this pull request
May 25, 2024
… recording (#1641) (#1673) * Workaround for zeros in a message's received timestamp with CycloneDDS - CycloneDDS doesn't support 'received_timestamps' and settling up zeros in message_info for that field. - Fallback to the timestamp from node clock in case of the CycloneDDS. Signed-off-by: Michael Orlov <[email protected]> * Fix typo in rmw_has_received_timestamp_support Signed-off-by: Michael Orlov <[email protected]> * Add one more check in tests that "recv_timestamp >= send_timestamp" - Also fixed typo in 'rwm_has_send_timestamp_support' in test Signed-off-by: Michael Orlov <[email protected]> * Revert workaround for `rmw_cyclonedds` in recorder.cpp - The fix will be done on the `rmw_cyclonedds` layer in the scope of the ros2/rmw_cyclonedds#491 Signed-off-by: Michael Orlov <[email protected]> --------- Signed-off-by: Michael Orlov <[email protected]> (cherry picked from commit b7d9b5b) Co-authored-by: Michael Orlov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
received_timestampsand settling up zeros inmessage_infofor that field.