Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add record, stop, start_discovery, stop_discovery and is_discovery_stopped services for rosbag2_transport::Recorder #1840

Open
wants to merge 9 commits into
base: rolling
Choose a base branch
from
Open

Add record, stop, start_discovery, stop_discovery and is_discovery_stopped services for rosbag2_transport::Recorder #1840

wants to merge 9 commits into from

Commits on Oct 17, 2024

  1. Add 'record' and 'stop' services 

    Signed-off-by: Sharmin Ramli <[email protected]>
    @sharminramli
    sharminramli committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    4072468 View commit details
    Browse the repository at this point in the history

  2. Reset event publisher exit flag 

    Signed-off-by: Sharmin Ramli <[email protected]>
    @sharminramli
    sharminramli committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    6df3340 View commit details
    Browse the repository at this point in the history

  3. Run topic discovery if stopped 

    Signed-off-by: Sharmin Ramli <[email protected]>
    @sharminramli
    sharminramli committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    56cd53d View commit details
    Browse the repository at this point in the history

  4. Add 'start_discovery', 'stop_discovery' services 

    Signed-off-by: Sharmin Ramli <[email protected]>
    @sharminramli
    sharminramli committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    9da1899 View commit details
    Browse the repository at this point in the history

  5. Add 'is_discovery_stopped' service 

    Signed-off-by: Sharmin Ramli <[email protected]>
    @sharminramli
    sharminramli committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    bf5f3c0 View commit details
    Browse the repository at this point in the history

  6. Clear topics on close in mock writer 

    Signed-off-by: Sharmin Ramli <[email protected]>
    @sharminramli
    sharminramli committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    2060659 View commit details
    Browse the repository at this point in the history

  7. Add recorder services tests 

    Signed-off-by: Sharmin Ramli <[email protected]>
    @sharminramli
    sharminramli committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    afdefb5 View commit details
    Browse the repository at this point in the history

  8. Fix naming errors in test 

    Signed-off-by: Sharmin Ramli <[email protected]>
    @sharminramli
    sharminramli committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    df51ea7 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2024

  1. Fix linting 

    Signed-off-by: Sharmin Ramli <[email protected]>
    @sharminramli
    sharminramli committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    2c1ed44 View commit details
    Browse the repository at this point in the history