Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] The time bounded snapshot feature #1844

Draft
wants to merge 6 commits into
base: rolling
Choose a base branch
from
Draft

[WIP] The time bounded snapshot feature #1844

wants to merge 6 commits into from

Commits on Oct 28, 2024

  1. Initial implementation for the time bounded snapshot 

    - Added the "--snapshot-duration" CLI option. Default value 0 indicates
that the snapshot will be limited by the --max-cache-size parameter
only. If the value is more than 0, the cyclic buffer for the snapshot
will be limited by both the series of messages duration and the maximum
cache size parameter.
- To override the upper bound by total messages size, the
"--maximum-cache-size" CLI option can be settled to 0.

Signed-off-by: Michael Orlov <[email protected]>
    @MichaelOrlov
    MichaelOrlov committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    f806243 View commit details
    Browse the repository at this point in the history

  2. Regenerate Python stub files (.pyi) 

    Signed-off-by: Michael Orlov <[email protected]>
    @MichaelOrlov
    MichaelOrlov committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    6e439e6 View commit details
    Browse the repository at this point in the history

  3. Bugfix for failing tests 

    Signed-off-by: Michael Orlov <[email protected]>
    @MichaelOrlov
    MichaelOrlov committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    3d637f0 View commit details
    Browse the repository at this point in the history

  4. Rename snapshot_duration_ms to the snapshot_duration 

    Signed-off-by: Michael Orlov <[email protected]>
    @MichaelOrlov
    MichaelOrlov committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    a126442 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2024

  1. Change type for snapshot_duration to the rclcpp::Duration 

    Signed-off-by: Michael Orlov <[email protected]>
    @MichaelOrlov
    MichaelOrlov committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    b4f2506 View commit details
    Browse the repository at this point in the history

  2. Add snapshot_duration handling in composable recorder and player nodes 

    Signed-off-by: Michael Orlov <[email protected]>
    @MichaelOrlov
    MichaelOrlov committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    351b529 View commit details
    Browse the repository at this point in the history