Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use foxy testing apt repos to install linters for Actions #463

Merged
merged 3 commits into from
Jul 20, 2020
+9 −9
Merged

Use foxy testing apt repos to install linters for Actions #463

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a9cf737
Use foxy testing apt repos to install linters for Actions
Jul 16, 2020
1e14627
Oops dockerfile needs to be focal
Jul 16, 2020
1924ecd
Requires specifying foxy as ros distribution as well
Jul 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,4 @@
# Run linters automatically on pull requests.
#
# ros-tooling/actino-ros-lint is relying on the latest APT binary packages.
# As of 2020-05-01, Eloquent is the latest release for which APT binary
# packages are available, which is why the Docker image is based on Eloquent.
name: Lint rosbag2
on:
pull_request:
Expand All @@ -12,14 +8,15 @@ jobs:
name: ament_copyright
runs-on: ubuntu-latest
container:
image: rostooling/setup-ros-docker:ubuntu-bionic-ros-eloquent-ros-base-latest
image: rostooling/setup-ros-docker:ubuntu-focal-ros-foxy-ros-base-testing-latest
steps:
# TODO(setup-ros-docker#7): calling chown is necessary for now
- run: sudo chown -R rosbuild:rosbuild "$HOME" .
- uses: actions/checkout@v2
- uses: ros-tooling/[email protected]
with:
linter: copyright
distribution: foxy
package-name: |
ros2bag
rosbag2_compression
Expand All @@ -34,14 +31,15 @@ jobs:
name: ament_xmllint
runs-on: ubuntu-latest
container:
image: rostooling/setup-ros-docker:ubuntu-bionic-ros-eloquent-ros-base-latest
image: rostooling/setup-ros-docker:ubuntu-focal-ros-foxy-ros-base-testing-latest
steps:
# TODO(setup-ros-docker#7): calling chown is necessary for now
- run: sudo chown -R rosbuild:rosbuild "$HOME" .
- uses: actions/checkout@v2
- uses: ros-tooling/[email protected]
with:
linter: xmllint
distribution: foxy
package-name: |
ros2bag
rosbag2
Expand All @@ -57,19 +55,20 @@ jobs:
ament_lint_cpp: # Linters applicable to C++ packages
name: ament_${{ matrix.linter }}
runs-on: ubuntu-latest
container:
image: rostooling/setup-ros-docker:ubuntu-bionic-ros-eloquent-ros-base-latest
strategy:
fail-fast: false
matrix:
linter: [cppcheck, cpplint, uncrustify]
container:
image: rostooling/setup-ros-docker:ubuntu-focal-ros-foxy-ros-base-testing-latest
steps:
# TODO(setup-ros-docker#7): calling chown is necessary for now
- run: sudo chown -R rosbuild:rosbuild "$HOME" .
- uses: actions/checkout@v2
- uses: ros-tooling/[email protected]
with:
linter: ${{ matrix.linter }}
distribution: foxy
package-name: |
rosbag2_compression
rosbag2_converter_default_plugins
Expand All @@ -83,7 +82,7 @@ jobs:
name: ament_${{ matrix.linter }}
runs-on: ubuntu-latest
container:
image: rostooling/setup-ros-docker:ubuntu-bionic-ros-eloquent-ros-base-latest
image: rostooling/setup-ros-docker:ubuntu-focal-ros-foxy-ros-base-testing-latest
strategy:
fail-fast: false
matrix:
Expand All @@ -95,5 +94,6 @@ jobs:
- uses: ros-tooling/[email protected]
with:
linter: ${{ matrix.linter }}
distribution: foxy
package-name: |
ros2bag