Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Rviz as a component #1140

Draft
wants to merge 1 commit into
base: rolling
Choose a base branch
from
Draft

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Feb 15, 2024

Related with this issue #1114

TODOs

  • Change name of the container (parameter?)
  • Do you want to launch rviz always as a component? (parameter?)

Signed-off-by: Alejandro Hernández Cordero <[email protected]>
@ahcorde ahcorde self-assigned this Feb 15, 2024
@roncapat
Copy link
Contributor

From my point of view, launching it always as a component (really, a component host) shall be fine.

@roncapat
Copy link
Contributor

What was the logic before, with the name of Rviz node?

@roncapat
Copy link
Contributor

roncapat commented Apr 14, 2024

@ahcorde can this one be merged for Jazzy?
Edit: it could be worth in the future to allow the user to select a different executor, for example a MultiThreadedExecutor.

@roncapat
Copy link
Contributor

Friendly ping @ahcorde :)

@james-yoo
Copy link

Any updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants