Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle time source exception #1285

Open
wants to merge 7 commits into
base: rolling
Choose a base branch
from
Open

Handle time source exception #1285

wants to merge 7 commits into from

Conversation

mjforan
Copy link

@mjforan mjforan commented Oct 7, 2024

When playing data from a bag I get this error:

terminate called after throwing an instance of 'std::runtime_error'
  what():  can't subtract times with different time sources [1 != 2]
Aborted (core dumped)

In my case this stems from the section of image_transport_display.hpp which computes the topic frequency.

My change catches this exception and makes it a warning on the topic property instead. If approved, I will apply the change to other applicable display interfaces.

@mjforan mjforan requested a review from ahcorde as a code owner October 7, 2024 18:18
@ahcorde
Copy link
Contributor

ahcorde commented Oct 9, 2024

Pulls: #1285
Gist: https://gist.githubusercontent.com/ahcorde/4bd58742fe756b64abe70574694d7abc/raw/e98f6ea463e22f33f6891e3e20be5b24f772ba89/ros2.repos
BUILD args: --packages-above-and-dependencies rviz_default_plugins --packages-above-and-dependencies rviz_default_plugins
TEST args: --packages-above rviz_default_plugins --packages-above rviz_default_plugins
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14686

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants