-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compressed Image Display #1288
base: rolling
Are you sure you want to change the base?
Compressed Image Display #1288
Conversation
Added a property to manually override image transport type. Rviz determines the transport by checking the topic name against image_transport conventions, e.g. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry about that, I have pushed a fix.
Please provide details so I can reproduce your issue. |
I would like to list the available image transports in a status message. However, The status message doesn't really matter except the transport->message type map is hard-coded, so we will want a warning if a new transport type is used which does not exist in the map. |
I noticed the Jazzy version of |
Can |
48133ae
to
40711b7
Compare
Addresses #738
I added
RosTopicMultiProperty
, which extendsRosTopicProperty
with a list of message types instead of one single type. This allows theImageDisplay
to show raw and compressed image topics together in its selector list.ImageDisplay
was altered to use animage_transport
subscriber so it can seamlessly display any installed image type. There is also a handful of frivolous changes to comply with the style linters.Tested with raw and compressed images. Assuming the other types work as well because the conversion happens in the
image_transport
library.Uncertainties:
RosTopicMultiProperty
: Is the name ok? Is there a simpler way to achieve my goal without adding a one-off property?plugin_description.xml
: I added the otherimage_transport
topic types here so Image Display appears in the "Add/By topic" menu. Adding the display will fail if the associatedimage_transport
plugin is not installed. Shouldros-$ROS_DISTRO-image-transport-plugins
be added topackage.xml
?