Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.4.0 Previewer #92
base: dev
Are you sure you want to change the base?
0.4.0 Previewer #92
Changes from 30 commits
35d0837
3dae85c
6ead747
e384aa7
51ae4f1
267d4e4
ecd81be
303f2d0
88a1a0b
3794d54
03c2d63
aa621b2
194dd83
e06b017
ea12e75
ac32754
278c84e
ffa9088
a0b2396
48aaf63
bee13a2
7c8d3fb
71fefc8
f48a1e1
c533aa1
a9cedaa
eb9e22e
8c3b031
041ea70
166b98b
1f66f27
fe2f2be
f312bec
a55e233
9dffad9
4b07825
fa42293
f9d8607
f51a6b4
0cbca9f
03657d1
f2b5791
8118996
d18ec1d
e3e0b89
25a13a8
97d6499
edce9d3
2790e2d
16af159
be8a7a3
b132fc9
cac4323
4db1880
240f642
cded059
563f0dc
a0febfe
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this mean that if you are processing images which are in a single folder (without the tilt series named subfolders), the processed data will live in a single folder as well rather than be organised into individual tilt series? We would have to account for this in the downstream plugins as well (maybe you have and I haven't gotten to that part yet...)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but only if so wished by the user. I've never had problems with this one as by default they are still organised into subfolders.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this accidentally apply binning twice, since binning is already passed to
batchruntomo
with<aligned_bin_factor>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. What it corrects is the wrong pixels size being passed into IMOD. This is because I've modified the code such that you can pre-bin the unaligned stacks first then do alignment. In that case, the old module would have the unbinned pixel size for alignment which is wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The aligned_bin_factor is for the post-alignment stack (i.e. _.ali.mrc), whereas the stack_bin_factor is for the pre-aligned one (i.e. .st).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it might be clearer to import this as
align_args
or something similarThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does
args["pixel_size"]
account for bin factors here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, because by definition VolZ is unbinned thickness in pixels
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would this bring up the magicgui? in
main.py
you've usedreturn_only=True
intoget_args
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would. However I'm not using this subroutine, but my old one directly from IMOD newstack (in align.py) instead so the GUI wouldn't come up like when you do command-line
o2r.aretomo.run project 2
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was
args
changed to_
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The function has to return something but we don't care about it so rather than storing it wasting memory I've set it to _