-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.4.0 beamshiftnaming #94
Open
elainehoml
wants to merge
20
commits into
0.4.0-beam-shift
Choose a base branch
from
0.4.0-beamshiftnaming
base: 0.4.0-beam-shift
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecating old files
Mdocs renaming
utils.rename
.<proj-name>_<tomogram-number>_<tilt-number>_<tilt-angle>.<ext>
. This makes the filenaming system compatible with Warp.MagicGUI
o2r.previewer
where the processing happens straight after parameter collection rather than having a separate run step.utils.rename.rename_all
andpreviewer.run_previewer
.utils.rename.rename_all
:.run(show=True)
, e.g.,AreTomo in Previewer
align.py
andaretomo.py
without a full rewrite - this will be necessary soon! Mostly to get the filenaming system to suit the new <tilt_number> system, i.e. acceptPosition_001_001_0.00.mrc
rather thanPosition_001_1_0.00.mrc
.Previewer early stops
_get_gpu_nvidia_smi
function was inside the motioncor object rather than exposed... should probably think about putting this out somewhere else that is more accessibleOt2Rec Report