Added the ability to set ReadAttributes & WriteAttributes for User Pool Client Settings and Added every AllowedOAuthScopes in CloudFormation YAML template file #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
First of all, thank you so much for this code! You really saved me the effort of doing it myself :)
I have added the ability to set ReadAttributes & WriteAttributes for the User Pool Client's Settings because, if you create a User Pool Client with these on and after that you set its Settings using your code, those get cleared. In:
https://docs.aws.amazon.com/cognito-user-identity-pools/latest/APIReference/API_UpdateUserPoolClient.html
It mentions:
"If you don't provide a value for an attribute, it will be set to the default value."
The docs do not specify the defaults for ReadAttributes & WriteAttributes but apparently those defaults are NULL.
I also added every possible AllowedOAuthScopes in CloudFormation YAML template file since the docs (see previous link) mention the following supported values:
"phone", "email", "openid", and "Cognito"
But, in reality the supported values are the ones in this pull request.
"Cognito" is really "aws.cognito.signin.user.admin" and this made my template to fail over and over again.
Not really a problem with your code, but I figured if someone came across it and wanted (as I did) to set "aws.cognito.signin.user.admin", seeing it in the YAML will aid them in getting the proper value and not waste 2 hs. of their lives (as I did). I also reported the fault in the docs to AWS.