Fix deprecation of pillow textsize() and getsize() methods #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello
As per #19, the code fails when running with Pillow 10+.
This PR replaces
textsize()withtextbbox()andgetsize()withgetbbox(), allowing for the altered return data structure of these methods - it's now a 4-tuple of x0, y0, x1, y1.x1 and y1 can be considered equivalent to width and height for our case.
I've only been able to test on the Enviro+, without particulate or noise monitoring (this is also broken for Bookworm, I think!). I only have one unit so I can't test it in indoor/outdoor mode.
Hope this is helpful.
James