Skip to content
This repository has been archived by the owner on Aug 11, 2023. It is now read-only.

Properly synchronize CancellableLoop. #211

Open
wants to merge 2 commits into
base: obsolete/master
Choose a base branch
from
Open

Properly synchronize CancellableLoop. #211

wants to merge 2 commits into from

Commits on Jun 27, 2015

  1. Properly synchronize CancellableLoop. 

    The write to the thread variable was guarded by a lock, but the reads were not. Also, operations in cancel and isRunning methods were not atomic. This could lead to visibility issues and data races (NPEs).
    okelepko committed Jun 27, 2015
    Configuration menu
    Copy the full SHA
    b5ff007 View commit details
    Browse the repository at this point in the history

  2. Properly synchronize CancellableLoop. 

    The write to the thread variable was guarded by a lock, but the reads were not. Also, operations in cancel and isRunning methods were not atomic. This could lead to visibility issues and data races (NPEs).
    okelepko committed Jun 27, 2015
    Configuration menu
    Copy the full SHA
    280c4a0 View commit details
    Browse the repository at this point in the history