Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update signs_description.xml #38

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

digitalheir
Copy link

Fixes first half of #37:

  • Aa18 is a denoted to contain Aa17, but also vice versa. I think it is clear that Aa17 does not include Aa18.
  • V98 is a denoted to contain V36, but also vice versa. I think it is clear that V98 does not include V36.
  • Y1 is a denoted to contain Y2, but also vice versa. I think it is clear that Y2 does not include Y1.
  • D32 is a denoted to contain D197, but also vice versa. I think it is clear that D197 does not include D32.

Fixes first half of rosmord#37:

- Aa18 is a denoted to contain Aa17, but also vice versa. I think it is clear that Aa17 does _not_ include Aa18.
- V98 is a denoted to contain V36, but also vice versa. I think it is clear that V98 does _not_ include V36.
- Y1 is a denoted to contain Y2, but also vice versa. I think it is clear that Y2 does _not_ include Y1.
- D32 is a denoted to contain D197, but also vice versa. I think it is clear that D197 does _not_ include D32.
@digitalheir
Copy link
Author

GitHub seems to have a problem with diffing this file. 😵‍💫

@rosmord
Copy link
Owner

rosmord commented May 1, 2023

I tend not to use git to manage this file, hence I'll consider the various changes by hand.
(Ideally, sign description should be managed by a web site).

This being said, the purpose of sign descriptions is not only to give a description of the signs, but also to help their retrieval. The reason I misused "part-of" is that it can be used transitively. Hence, for instance, starting with Aa18, and looking signs which contain it, one will find in a first step Aa17, then signs which contain Aa17, which might be the signs looked for by the user.

Now, it's a dirty trick, and a better definition of variants (or, to be more precise, a full use of the various variant level I have proposed) would be cleaner. But it takes a lot of time.

@rosmord
Copy link
Owner

rosmord commented Apr 29, 2024

for the problem with git diff : the file is really huge. At some point, I might consider a system with multiple files for sign information, which would be easier to manage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants