add some attributs to EEIPClient.java #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[-] remove unwanted imports [+] add an attribut for ConfigurationAssemblyInstanceID, this attribut value was provided with a constant value, and it is not common for all PLC devices, it should be generic as well as other connection path parameters . [+] add an attribut transportTrigger, same problem as before, it value was constant in the library, but transportTrigger could be generic so that we can use different transport trigger modes with implicit connection. [+] add two function to detect target data length, these function were implemented in dot net version of this EEIP library, but it was not implemented here in the java version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[-] remove unwanted imports
[+] add an attribut for ConfigurationAssemblyInstanceID, this attribut value was provided with a constant value in EEIP library, it uses a value that is provided within connection paths, its value is not common for all PLC devices so i suggest to make it generic.
[+] add an attribut transportTrigger, same problem as before, its value was constant in the library, but transportTrigger could be generic so that we can use different transport trigger modes with implicit connection.
[+] add two function to detect data length, these functions were implemented in dot net version of this EEIP library, but it was not implemented here in the java version.