Rename plugins to inputs #45
Open
+98
−176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Telegraf works with the concept of plugins for both inputs and outputs, making it explicit which kind of plugin are we handling in each section is important to avoid mistakes and confusions. After this commit I intend to improve this ansible role in order to allow multiple output plugins also, which will also make 'influxdb' optional as output.
I've refactored the template in order to enable multiple 'outputs'. This required also refactoring the defaults/main.yml file to be in accordance with the template. Fix rossmcdonald#30
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ho @rossmcdonald !
First of all, thanks for the telegraf ansible role!
I've made some modifications looking for a more broad approach, supporting multiple outputs.
If you have any comments, please, feel free to make the changes or request them.
Regards!
ps.: I haven't tested it yet.