Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Rails 6 and 7, drop support for Rails 5 #128

Draft
wants to merge 13 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
73 changes: 0 additions & 73 deletions .circleci/config.yml

This file was deleted.

63 changes: 63 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,63 @@
name: Tests

on:
pull_request:
branches:
- '*'
push:
branches:
- main
workflow_call:

jobs:
test:
runs-on: ubuntu-latest
strategy:
matrix:
ruby: ['3.0', '3.1', '3.2', '3.3']
gemfile:
- rails_6.0
- rails_6.1
- rails_7.0
- rails_7.1
# Example for excluding a specific Ruby version with a specific Gemfile
# exclude:
# - ruby: '3.0'
# gemfile: 'rails_7.1'

env:
BUNDLE_GEMFILE: ${{ github.workspace }}/gemfiles/${{ matrix.gemfile }}.gemfile
BUNDLE_PATH_RELATIVE_TO_CWD: true

steps:
- uses: actions/checkout@v4

- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: ${{ matrix.ruby }}
bundler: default
bundler-cache: true
rubygems: latest

- name: Setup Node
uses: actions/setup-node@v4
with:
node-version-file: .node-version
cache: yarn
cache-dependency-path: './test/sample/yarn.lock'

- name: Node version
run: |
node --version

- name: Install NPM packages for sample app
run: |
bundle exec rake app:yarn_install_frozen

- name: StandardRb check
run: bundle exec standardrb

- name: Run tests
run: |
bundle exec rake test
2 changes: 0 additions & 2 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,3 @@
**/log/
**/node_modules/
.byebug_history
.ruby-gemset
.ruby-version
1 change: 1 addition & 0 deletions .node-version
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
20.13.1
1 change: 1 addition & 0 deletions .ruby-version
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
3.3.0
3 changes: 1 addition & 2 deletions .standard.yml
Original file line number Diff line number Diff line change
@@ -1,2 +1 @@
ignore: # default: []
- 'test/sample/node_modules/**/*'
ruby_version: 2.7
21 changes: 0 additions & 21 deletions Appraisals

This file was deleted.

2 changes: 1 addition & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ source "https://rubygems.org"
gemspec

group :development, :test do
unless ENV["TRAVIS"]
unless ENV["CIRCLE_CI"]
gem "guard", require: false
gem "guard-minitest", require: false
gem "pry"
Expand Down
Loading
Loading