fix(api-client): do not reauth if no credentials are available #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bara-m
requested changes
Apr 5, 2024
igor-erziak
force-pushed
the
igor/no-reauth-without-credentials
branch
from
dac1ee8 to
d937dae
Compare
igor-erziak
force-pushed
the
igor/no-reauth-without-credentials
branch
from
d937dae to
033063f
Compare
bara-m
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the api client tries to re-authenticate using credentials (username + password) in case the token is invalid (401 response is received on any request). However, attempting this when there were no credentials configured when creating the client doesn't make sense. It results in a misleading 400 error saying
{"password": ["This field may not be blank."]}.This change fixes it by transparently returning the 401 when the token is invalid and the credentials are missing. This way, the code using the client can deal with the invalid token issue on its own (e.g. display a user friendly message).