-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unique log file name and FAT long file name support #212
Conversation
5e0eff0
to
edf7365
Compare
edf7365
to
1ba4c15
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please strip trailing whitespace on all new lines.
Even better, configure your editor to do it for you!
In fact, I should add a check in the PR-CI that would automatically notify the author if there are traling whitespaces or other formatting issues... TBD. |
I wonder... While we are at it, maybe we can use the craft name instead of RTFL_ prefix. |
bf8044a
to
207eeaf
Compare
Done both. 0a189fa
Sounds useful. 207eeaf Please take another look |
Sorry to be PITA. What the craft name is empty? Now it would have two underscores. |
Also add a few test cases to cover the added functions.
Don't include extra '_' if craft name is unset.
ef7f6af
to
f15244f
Compare
I thought about it and I thought it's fine as any illegal chars all turn to extra underscores. (Tested with https://github.com/gongtao0607/rotorflight-firmware/tree/RF-flashfs) |
This commit adds support for long FAT file names, and applies it to the BB log file names in MSC.
This PR changes the naming schema of the log files and adds FAT LFN support to emfat.
If a proper timestamp is detected in a BB log, the emfat will name it with the timestamp -- so you don't get a collection of
rtfl_001 (X).bbl