Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unique log file name and FAT long file name support #212

Merged
merged 6 commits into from
Jan 1, 2025

Conversation

gongtao0607
Copy link
Contributor

@gongtao0607 gongtao0607 commented Dec 27, 2024

This PR changes the naming schema of the log files and adds FAT LFN support to emfat.

If a proper timestamp is detected in a BB log, the emfat will name it with the timestamp -- so you don't get a collection of rtfl_001 (X).bbl

Screenshot 2024-12-27 132333
Screenshot 2024-12-27 132600
Screenshot 2024-12-27 132843

@gongtao0607 gongtao0607 changed the title Nicer log file name and FAT long file name support Unique log file name and FAT long file name support Dec 27, 2024
@gongtao0607 gongtao0607 marked this pull request as ready for review December 28, 2024 01:47
Copy link
Owner

@rotorflight rotorflight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please strip trailing whitespace on all new lines.
Even better, configure your editor to do it for you!

@rotorflight
Copy link
Owner

In fact, I should add a check in the PR-CI that would automatically notify the author if there are traling whitespaces or other formatting issues... TBD.

@rotorflight
Copy link
Owner

I wonder... While we are at it, maybe we can use the craft name instead of RTFL_ prefix.
With spaces and other special characters replaced with _ or something.

@gongtao0607
Copy link
Contributor Author

Please strip trailing whitespace on all new lines. Even better, configure your editor to do it for you!

Done both. 0a189fa

I wonder... While we are at it, maybe we can use the craft name instead of RTFL_ prefix. With spaces and other special characters replaced with _ or something.

Sounds useful. 207eeaf

Screenshot 2024-12-28 173835

Please take another look

@rotorflight
Copy link
Owner

Sorry to be PITA. What the craft name is empty? Now it would have two underscores.

@gongtao0607
Copy link
Contributor Author

gongtao0607 commented Dec 30, 2024

Sorry to be PITA. What the craft name is empty? Now it would have two underscores.

I thought about it and I thought it's fine as any illegal chars all turn to extra underscores.
Anyway here's the change: f15244f

(Tested with https://github.com/gongtao0607/rotorflight-firmware/tree/RF-flashfs)

@rotorflight rotorflight merged commit 3a24d57 into rotorflight:master Jan 1, 2025
1 check passed
@gongtao0607 gongtao0607 deleted the emfat_lfn branch January 1, 2025 18:57
gongtao0607 added a commit to gongtao0607/rotorflight-firmware that referenced this pull request Jan 2, 2025
This commit adds support for long FAT file names, and applies it to the BB log file names in MSC.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants