Fixes for base16 theme #1925
Open
Fixes for base16 theme #1925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey @tancnle, anything I can do to help get this merged? |
4 tasks
skipkayhil
force-pushed
the
fix-base16-theme
branch
from
33494db
to
8c03bf0
Compare
This helps make it very obvious which tokens will end up with the same base16 color.
Previously
- base0B: Strings, Inherited Class, Markup Code, Diff Inserted
Now:
- base09 - Integers, Boolean, Constants, XML Attributes, Markup Link Url
^^^^^^^^
Variables: - base08 - Variables, XML Tags, Markup Link Text, Markup Lists, Diff Deleted Functions: - base0D - Functions, Methods, Attribute IDs, Headings
skipkayhil
force-pushed
the
fix-base16-theme
branch
from
8c03bf0
to
afb4905
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Commits are split into refactor/changes/additions, so reviewing them individually should be much easier than the final diff.
Base16 ruby code highlighting reference: https://base16.vercel.app/previews/base16-default-dark
There are still a few discrepancies between the After and the reference highlighting:
requireis highlighted like a keyword andattr_accessor,print, andputsare highlighted like methods, but the Rouge ruby lexer defines all of these asName::Builtin. I think most of the Rouge's rubyName::Builtinshould just be removed so that they can just be methods, but that isn't related to the Base16 theme.selfis correctly highlighted like a keyword in the reference, but the lexer currently says its aName::Class.Person::nameas aName, but I think it should be possible to update the lexer to correctly identity them asName::FunctionExample Screenshots
Before:
After: