Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed corner cases of svg-tag--cursor-function #19

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mkvoya
Copy link

@mkvoya mkvoya commented Jan 2, 2022

This PR fixes two corner cases in svg-tag--cursor-function:

  1. (+ (point) 1) might exceed the end of the buffer;
  2. end might be nil.

@rougier
Copy link
Owner

rougier commented Jan 3, 2022

Thanks. Can you reduce the PR? GitHub highlights some changes that do not appear to be actual change (I don't know why)
Also, can you sign the Emacs copyright assignment?

@mkvoya
Copy link
Author

mkvoya commented Jan 4, 2022

Thanks. Can you reduce the PR? GitHub highlights some changes that do not appear to be actual change (I don't know why)

That is because of the indent changes. I added a when clause which makes the code indent more.

Also, can you sign the Emacs copyright assignment?

I have sent the email and will update here later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants