Bugfixes and some minor cleanup #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also put the definition of the global mode on a single line, resulting in the name of the mode being properly colored. Even when doing this, the length of the line stays below 80 characters.
Use either `cond' or `when'. In the latter case, collect the conditions in just one place.
- It is better to avoid using `if' when there is no ELSE part. - It is better to avoid using `when' when the returned value matters.
Or rather employ some tricks to avoid having to either break with how the code is automatically indented or else ending up with long lines or other unfortunate results.
Also change matched text to match the examples.
This reverts commit 0e0ea48. At the time `match-string' is evaluated it, at least sometimes, returns nil (I suspect it always does), which then causes `substring-no-properties' to error because it expects a string as argument. Alternatively, if this happens to actually return non-nil in some cases, then `match-string-no-properties' should be used instead, because, like `match-string', that won't error when the requested match-data is empty.
|
Now I've also added two bugfixes. |
|
Thansk @tarsius and sorry for long delay in my answer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am going through my local clones and discovered this fixup branch.
I hope these changes are uncontroversial.