Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

指定した GitHub Discussion ID にコメントを追加する reusable workflow #60

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
+92 −0
Draft

指定した GitHub Discussion ID にコメントを追加する reusable workflow #60

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a053328
draft update
TomckySan Jul 26, 2024
dd39493
末尾改行
TomckySan Jul 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Loading
Loading status checks…
末尾改行
@TomckySan
TomckySan authored Jul 26, 2024
commit dd39493796e030fb87abd04a84f9a1e4c2c8e6ac
2 changes: 1 addition & 1 deletion .github/workflows/add_discussion_comment.yml
View file
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imo:

ファイル名の案:

  • add_gh_discussion_comment.yml
    • 他 workflow と同じように gh は付けたほうが良い
  • add_comment_to_gh_discussion.yml
    • もう少し具体的な名前にする
  • append_comment_to_gh_discussion.yml
    • append で後ろに追加するニュアンスにする？

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: 全体的に YAML のインデントは 2 でお願いしますw

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

まじごめんなさいwww 🙏🏻 🙇🏻

Original file line number Diff line number Diff line change
@@ -89,4 +89,4 @@ jobs:
});

await createDisussionComment(github, DISCUSSION_ID, body);
}
}