switch from .NET Core 3.1 to ,NET Standard 2.0

route4me · Oct 28, 2021 · 19b812e · 19b812e
1 parent 8df2db9
commit 19b812e
Show file tree

Hide file tree

Showing 4 changed files with 23 additions and 7 deletions.
diff --git a/route4me-csharp-sdk/CHANGELOG.md b/route4me-csharp-sdk/CHANGELOG.md
@@ -1,7 +1,17 @@
 # Changelog
 All notable changes to this project will be documented in this file.
 
-## [1.1.0.0] - 2021-10-07
+## [1.1.1.0] - 2021-10-28
+
+### Changed
+
+- Route4MeSDKLibrary is Switched from .NET Core 3.1 to .NET Standard 2.0.
+- Threading is optimized for Route4MeManager and Route4MeManagerV5
+- 3rd party dependencies are updated and consolidated
+- Code style is adjusted
+- Code is cleaned up
+
+## [1.1.0.0] - 2021-10-20
 
 ### Added
 

diff --git a/route4me-csharp-sdk/Route4MeSDKLibrary/FastProcessing/FastBulkRemoveContacts.cs b/route4me-csharp-sdk/Route4MeSDKLibrary/FastProcessing/FastBulkRemoveContacts.cs
@@ -57,7 +57,7 @@ private void RemoveContactsChunks(List<int> chunk)
             if (PrintMessagesOnConsole)
                 Console.WriteLine(removed
                     ? $"The chunk of the {chunk.Count} contacts removed --- {TotalRemovedContacts}"
-                    : $"Cannot remove the chunk of the contacts: {Environment.NewLine}" + string.Join(',', chunk));
+                    : $"Cannot remove the chunk of the contacts: {Environment.NewLine}" + string.Join(",", chunk.Select(x => x.ToString())));
 
             if (removed) TotalRemovedContacts += chunk.Count;
         }

diff --git a/route4me-csharp-sdk/Route4MeSDKLibrary/HttpClientHolderManager.cs b/route4me-csharp-sdk/Route4MeSDKLibrary/HttpClientHolderManager.cs
@@ -81,8 +81,13 @@ private static void OnTimerCallback()
                         keysToRemove.Add(kvp.Key);
 
                 foreach (var key in keysToRemove)
-                    if (HttpClientWrappers.Remove(key, out var removed))
+                {
+                    if (HttpClientWrappers.TryGetValue(key, out var removed))
+                    {
+                        HttpClientWrappers.Remove(key);
                         removed.HttpClient.Dispose();
+                    }
+                }
             }
         }
 

diff --git a/route4me-csharp-sdk/Route4MeSDKLibrary/Route4MeSDKLibrary.csproj b/route4me-csharp-sdk/Route4MeSDKLibrary/Route4MeSDKLibrary.csproj
@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFramework>netcoreapp3.1</TargetFramework>
+    <TargetFramework>netstandard2.0</TargetFramework>
     <Authors>Oleg Guchashvili</Authors>
     <PackageRequireLicenseAcceptance>true</PackageRequireLicenseAcceptance>
     <Description>Route4Me Route Optimization SaaS C# SDK (.net core framework).
@@ -16,13 +16,13 @@ The service is typically used by organizations who must route many drivers to ma
     <RepositoryUrl>https://github.com/route4me/route4me-net-core/tree/master/route4me-csharp-sdk</RepositoryUrl>
     <RepositoryType>git</RepositoryType>
     <PackageTags>Route4Me, Route Optimization, SDK, GIS</PackageTags>
-    <Version>1.1.0.0</Version>
+    <Version>1.1.1.0</Version>
     <PackageReleaseNotes>Changed the classes: DataContractResolver, FastBulkGeocoding, FastFileReading, PropertyValidation, Route4MeManagerV5
 Added the classes: AddressBookContact (V5), AddressBookContactsResponse (V5), AddressBookParameters (V5), FastFileReading, FastValidateData
 
 See https://github.com/route4me/route4me-net-core/blob/master/route4me-csharp-sdk/CHANGELOG.md for release note details.</PackageReleaseNotes>
-    <AssemblyVersion>1.1.0.0</AssemblyVersion>
-    <FileVersion>1.1.0.0</FileVersion>
+    <AssemblyVersion>1.1.1.0</AssemblyVersion>
+    <FileVersion>1.1.1.0</FileVersion>
   </PropertyGroup>
 
   <ItemGroup>
@@ -37,6 +37,7 @@ See https://github.com/route4me/route4me-net-core/blob/master/route4me-csharp-sd
     <PackageReference Include="Microsoft.Extensions.Configuration.Json" Version="5.0.0" />
     <PackageReference Include="Newtonsoft.Json" Version="13.0.1" />
     <PackageReference Include="SocketIoClientDotNet.Standard" Version="0.0.6" />
+    <PackageReference Include="System.ComponentModel.Annotations" Version="5.0.0" />
     <PackageReference Include="System.Configuration.ConfigurationManager" Version="5.0.0" />
   </ItemGroup>