Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1527 2024 03 21 #1548

Closed

Conversation

rajesh-jonnalagadda
Copy link

/claim #1527

phase1:
This PR addresses the following changes:

  1. Resolved issues related to out-of-order sorting and filtering.
  2. Implemented tabs feature to facilitate customized data viewing:
    Tab 1: "DB view" displays only database data.
    Tab 2: "Local playground" shows only local data.
    Tab 3: "Old view" allows viewing both database and local data.
  3. In user filters added an option to include local data in the "Old view" during sorting and filtering.

Please check the approach in the link below and review the changes made in this pull request and provide feedback on any further improvements that may be necessary. Your input is appreciated.

screen-recording link: https://www.loom.com/share/28025d9212154fad83347632d846652c?sid=5d6abdd8-0274-4ce9-8d42-5dbf105359d1

Copy link

vercel bot commented Mar 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
rowy-typedoc ✅ Ready (Inspect) Visit Preview Mar 21, 2024 11:59am

Copy link

vercel bot commented Mar 21, 2024

@rajeshj11 is attempting to deploy a commit to the Rowy Team on Vercel.

A member of the Team first needs to authorize it.

@rajesh-jonnalagadda
Copy link
Author

@bofeiw Please review the approach and changes.

@rajesh-jonnalagadda
Copy link
Author

@harinij Can you please get this approach reviewed? if any changes are needed let me know.

@harinij
Copy link
Member

harinij commented Apr 25, 2024

@rajeshj11 thansk for your submission. The tabs based solution would not work here as it would lead to issues with multiple views of the same data and mismatch with exisiting design. Closing this for now. We will share a more detailed design spec in the future to ensure smoother dev implementation.

@harinij harinij closed this Apr 25, 2024
@rajesh-jonnalagadda rajesh-jonnalagadda deleted the bug-1527-2024-03-21 branch August 31, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants