Fixes #9
Open
Fixes #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latter is deprecated since glib 2.2, so this clears up a lot of deprecation warnings.
clang -Wall complains that type_to_icon is using abs on a time_t. It suggests using labs instead, but that'll cause the same problem on machines with 64-bit time_t. Use fabs and a cast to double instead.
clang -Wall otherwise complains about the function not being used.
The latter is deprecated, so this fixes a warning. Despite the Xkb prefix the former is in libX11, which we already link with. Johaan Strojandogg suggested (and tested) this change in 2012, although I don't think he ever submitted it: http://www.linuxquestions.org/questions/programming-9/warning-'xkeycodetokeysym'-is-deprecated-how-do-i-switch-to-xkbkeycodetokeysym-4175442778/
clang -Wall (correctly) complains that we shouldn't be using values in an enum type that haven't been defined. The other enums in global.h already have UNKNOWN values.
These were added elsewhere but not here.
Found by scan-build.
Found by scan-build.
"Benutzter" (used) for "Benutzer" (user).
|
Rebased to remove the I've been using rox-filer with these patches heavily since 2016, and haven't run into any further problems, so I'm pretty confident they're OK now... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bunch of minor fixes, mostly clearing up compiler warnings.
The g_basename removal change is the biggest one here. I don't think there's anything especially complex in there but it touches quite a bit of the code.