Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix / Fix n+1 queries problem #1

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

roxanaoana24
Copy link
Owner

@roxanaoana24 roxanaoana24 commented Sep 20, 2023

Fixes: AACraiu#1

Changes

Fixed n+1 queries problem by changing ScoresController#user_feed in order to implement eager loading instead of lazy loading.

Before
Captură de ecran din 2023-09-20 la 13 41 37

After
Captură de ecran din 2023-09-20 la 13 42 02

@cristian-scarisoreanu
Copy link

You should fix the rubocop warnings.

@cristian-scarisoreanu
Copy link

The title should usually be Hotfix / [Name of the issue]

@cristian-scarisoreanu
Copy link

You should add the issue URL to the PR

@roxanaoana24 roxanaoana24 changed the title hotfix/improve-scores-feed-performance hotfix/n+1 queries problem Sep 25, 2023
@roxanaoana24 roxanaoana24 changed the title hotfix/n+1 queries problem Hotfix / Fix n+1 queries problem Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve scores feed performance
2 participants