Add support for getting ECS style authentication #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running `Credstash` inside ECS as a docker container, the authentication is being "injected" as an assumed role. This PR adds support for checking whether the context the task is being ran in is ECS, if it is, it will instanciate the special object to grab the auth from the ECS proxy. BEFORE: When trying to run the task, it would assume the role of the instance it's running on (which may or may not have the permissions you want). ``` User `<instance-role>' is not authorized to perform `<specific-task>' on resource `<some-resource>' ``` After: Task is running as expected and assuming the correct role. All tests are passing Some more changes * Instead of requiring and customizing the AWS sdk in multiple places, put it in a single file and customizing only there. * Added tests for the right credentials being passed in * Checking whether we are in ECS context based on a special ENV var only passed from there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
Credstashinside ECS as a docker container, theauthentication is being "injected" as an assumed role.
This PR adds support for checking whether the context the task is being
ran in is ECS, if it is, it will instanciate the special object to grab
the auth from the ECS proxy.
BEFORE:
When trying to run the task, it would assume the role of the instance
it's running on (which may or may not have the permissions you want).
After:
Task is running as expected and assuming the correct role.
All tests are passing
Some more changes
put it in a single file and customizing only there.
passed from there