Add negative hex literals

rozukke · Sep 20, 2024 · 4f0969d · 4f0969d
1 parent 4d7a0d8
commit 4f0969d
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 15 deletions.
diff --git a/src/lexer/mod.rs b/src/lexer/mod.rs
@@ -198,17 +198,20 @@ impl Cursor<'_> {
         let prefix = self.pos_in_token();
         self.take_while(|c| !is_whitespace(c));
         let str_val = self.get_range(start..self.abs_pos());
-        let value = match u16::from_str_radix(str_val, 16) {
-            Ok(value) => value,
-            Err(e) => match e.kind() {
-                IntErrorKind::PosOverflow => {
-                    return Err(error::lex_invalid_lit(
-                        (start - prefix..self.abs_pos()).into(),
-                        self.src(),
-                        e,
-                    ));
-                }
-                _ => return Ok(self.ident()),
+        let value = match i16::from_str_radix(str_val, 16) {
+            Ok(value) => value as u16,
+            Err(_) => match u16::from_str_radix(str_val, 16) {
+                Ok(value) => value,
+                Err(e) => match e.kind() {
+                    IntErrorKind::PosOverflow => {
+                        return Err(error::lex_invalid_lit(
+                            (start - prefix..self.abs_pos()).into(),
+                            self.src(),
+                            e,
+                        ))
+                    }
+                    _ => return Ok(self.ident()),
+                },
             },
         };
 
@@ -373,23 +376,30 @@ mod test {
     fn hex_correct_value() {
         let mut lex = Cursor::new("0x1234");
         let res = lex.advance_token().unwrap();
-        assert!(res.kind == TokenKind::Lit(LiteralKind::Hex(0x1234)))
+        assert_eq!(res.kind, TokenKind::Lit(LiteralKind::Hex(0x1234)))
     }
 
     #[test]
     fn hex_too_large() {
         let mut lex = Cursor::new("xFFFF x10000");
         let res = lex.advance_token().unwrap();
-        assert!(res.kind == TokenKind::Lit(LiteralKind::Hex(0xFFFF)));
+        assert_eq!(res.kind, TokenKind::Lit(LiteralKind::Hex(0xFFFF)));
         // Whitespace
         assert!(lex.advance_real().is_err());
     }
 
+    #[test]
+    fn hex_neg() {
+        let mut lex = Cursor::new("x-4");
+        let res = lex.advance_token().unwrap();
+        assert_eq!(res.kind, TokenKind::Lit(LiteralKind::Hex((-0x4i16) as u16)))
+    }
+
     #[test]
     fn hex_leading_0() {
         let mut lex = Cursor::new("0x3000");
         let res = lex.advance_token().unwrap();
-        assert!(res.kind == TokenKind::Lit(LiteralKind::Hex(0x3000)))
+        assert_eq!(res.kind, TokenKind::Lit(LiteralKind::Hex(0x3000)))
     }
 
     #[test]

diff --git a/src/parser.rs b/src/parser.rs
@@ -423,7 +423,8 @@ impl AsmParser {
     }
 }
 
-// Convenient way to pass around bit limits
+/// Convenient way to pass around bit limits
+#[derive(Debug)]
 pub enum Bits {
     Signed(u8),
     Unsigned(u8),