Automatically insert HALT at end of bytecode, before running
#51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rozukke
reviewed
Nov 28, 2024
| concat!("exception: ", $fmt, ", exiting") | ||
| $($tt)* | ||
| ); | ||
| std::process::exit(0xEE); |
There was a problem hiding this comment.
What is the significance of 238 as an exit code?
There was a problem hiding this comment.
No reason, it's just unique. If used in a script it can be easily checked if the error was with the lc3 program.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents program counter running through no-ops to the end of memory.
Program will also now panic if program counter is in invalid memory region, although
pc = u16::MAXis still used to signify a halt.Replace panics due to incorrect bytecode with custom
exception!macro.