Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up CMake #23

Merged
merged 4 commits into from
Jun 20, 2024
Merged

Clean up CMake #23

merged 4 commits into from
Jun 20, 2024

Conversation

rozukke
Copy link
Owner

@rozukke rozukke commented Jun 9, 2024

Clean up options for CMake config

@rozukke rozukke closed this Jun 9, 2024
@rozukke rozukke deleted the fix/cmake-cleanup branch June 9, 2024 13:35
@rozukke rozukke restored the fix/cmake-cleanup branch June 9, 2024 13:36
@rozukke rozukke reopened this Jun 9, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cpp-linter Review

Click here for the full clang-format patch
diff --git a/test/minecraft_tests.cpp b/test/minecraft_tests.cpp
index f17de06..23ed6d7 100644
--- a/test/minecraft_tests.cpp
+++ b/test/minecraft_tests.cpp
@@ -155 +155 @@ TEST_CASE("Test the main mcpp class") {
-// Requires player joined to server, will throw serverside if player is not 
+// Requires player joined to server, will throw serverside if player is not

Have any feedback or feature suggestions? Share it here.

test/minecraft_tests.cpp Outdated Show resolved Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot dismissed their stale review June 19, 2024 07:38

outdated suggestion

@rozukke rozukke merged commit fb2b92f into main Jun 20, 2024
2 checks passed
@rozukke rozukke deleted the fix/cmake-cleanup branch June 20, 2024 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant