Fix getPlayerTilePosition() and add corresponding test case #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rozukke
requested changes
Jun 10, 2024
nhatdongdang
force-pushed
the
fix/get-player-tile-position
branch
from
9ce735f to
c7da208
Compare
nhatdongdang
force-pushed
the
fix/get-player-tile-position
branch
from
1917223 to
653c05f
Compare
rozukke
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request fixes the incomplete command in the
getPlayerTilePosition()function.Changes:
player.toplayer.getTile.Linked Issue
This pull request fixes #28