Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix get/set(PlayerTilePosition) offset by 1 #33

Closed
wants to merge 4 commits into from
Closed

Fix get/set(PlayerTilePosition) offset by 1 #33

wants to merge 4 commits into from

Conversation

johnathanchann
Copy link
Contributor

@johnathanchann johnathanchann commented Jun 11, 2024

Related Issue

Fixes #30

Type of Change

  • Offset getTilePosition by -1
  • Offset setTilePosition by +1

Tested with test_suite

----------------------------------------------------------

2/2 Testing: full
2/2 Test: full
Command: "/mnt/c/Users/yeefh/documents/mcpp/build/test/test_suite"
Directory: /mnt/c/Users/yeefh/documents/mcpp/build
"full" start time: Jun 12 00:07 AEST
Output:
----------------------------------------------------------
[doctest] doctest version is "2.4.9"
[doctest] run with "--help" for options
===============================================================================
[doctest] test cases:  6 |  6 passed | 0 failed | 0 skipped
[doctest] assertions: 40 | 40 passed | 0 failed |
[doctest] Status: SUCCESS!
<end of output>
Test time =   0.92 sec
----------------------------------------------------------
Test Passed.
"full" end time: Jun 12 00:07 AEST
"full" time elapsed: 00:00:00
----------------------------------------------------------

End testing: Jun 12 00:07 AEST

@johnathanchann johnathanchann deleted the fix/get-set-tile-pos branch June 12, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getPlayerPosition and getPlayerTilePosition are equivalent
1 participant