Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix get/set(PlayerTilePosition) offset by 1 #34

Merged
merged 2 commits into from
Jun 12, 2024
Merged

Fix get/set(PlayerTilePosition) offset by 1 #34

merged 2 commits into from
Jun 12, 2024

Conversation

johnathanchann
Copy link
Contributor

Related Issue

Fixes #30

Type of Change

  • Offset getTilePosition by -1
  • Offset setTilePosition by +1

Tested with test_suite

----------------------------------------------------------

2/2 Testing: full
2/2 Test: full
Command: "/mnt/c/Users/yeefh/documents/mcpp/build/test/test_suite"
Directory: /mnt/c/Users/yeefh/documents/mcpp/build
"full" start time: Jun 12 00:07 AEST
Output:
----------------------------------------------------------
[doctest] doctest version is "2.4.9"
[doctest] run with "--help" for options
===============================================================================
[doctest] test cases:  6 |  6 passed | 0 failed | 0 skipped
[doctest] assertions: 40 | 40 passed | 0 failed |
[doctest] Status: SUCCESS!
<end of output>
Test time =   0.92 sec
----------------------------------------------------------
Test Passed.
"full" end time: Jun 12 00:07 AEST
"full" time elapsed: 00:00:00
----------------------------------------------------------

End testing: Jun 12 00:07 AEST

Copy link
Owner

@rozukke rozukke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some consistency updates and should be good to go - make sure that player tests correspond to this functionality too.

src/mcpp.cpp Outdated Show resolved Hide resolved
@rozukke rozukke merged commit 48daadf into rozukke:main Jun 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getPlayerPosition and getPlayerTilePosition are equivalent
2 participants