Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Support for Player Joining on Minecraft Spigot Server in CI workflow #40

Merged
merged 5 commits into from
Jun 16, 2024
Merged

Add Support for Player Joining on Minecraft Spigot Server in CI workflow #40

merged 5 commits into from
Jun 16, 2024

Conversation

nhatdongdang
Copy link
Contributor

Description

This pull request includes the configurations to automate the testing related to the player during the CI process.

Changes

  • Integrated the Minecraft-Console-Client for simulating player joins.
  • Updated the CI configuration file for setting up the bot.

rozukke
rozukke reviewed Jun 16, 2024
View reviewed changes
Copy link
Owner

@rozukke rozukke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Maybe add a comment going slightly into detail how this works? Otherwise seems like a very valuable addition.

rozukke
rozukke approved these changes Jun 16, 2024
View reviewed changes
Copy link
Owner

@rozukke rozukke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers, looks good.

@rozukke rozukke merged commit 7cc67e4 into rozukke:main Jun 16, 2024
2 checks passed
@nhatdongdang nhatdongdang deleted the feature/ci-support-player-joining branch September 9, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rozukke rozukke rozukke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nhatdongdang @rozukke