Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chunk iterator and fix getter #73

Merged
merged 3 commits into from
Aug 12, 2024

Conversation

nhatdongdang
Copy link
Contributor

This pull request introduces the following enhancements to the Chunk class:

  1. Addition of Iterator class:

    • Implemented an Iterator class within Chunk to enable traversal of the 3D block data using standard iterator patterns.
    • Added the begin() and end() methods to support range-based loops and iterator-based algorithms.
  2. Doxygen-style documentation:

    • Documented the Iterator class, including all its methods (operator*, operator->, operator++ (prefix and postfix), operator==, operator!=), as well as the begin() and end() methods.
    • Provided clear descriptions of the iterator's functionality and the purpose of each method.
  3. Test Cases:

    • Tests include verifying iteration over the Chunk data.
  4. Fix getter:

    • Fix chunk getter method.

@nhatdongdang nhatdongdang force-pushed the feature/chunk-iterator branch from e4c87c2 to 2d99dd6 Compare August 12, 2024 08:27
Copy link
Owner

@rozukke rozukke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers for the fix, approaching enough to make a release soon 👍

@rozukke rozukke merged commit d0a4b5c into rozukke:main Aug 12, 2024
2 checks passed
@nhatdongdang nhatdongdang deleted the feature/chunk-iterator branch August 12, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants